[TwigComponent] escape nesting separator with ::
#1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
fix/dash-in-nested-attribute
branch
from
b06bcaa to
e647da1
Compare
kbond
changed the title
::::
smnandre
reviewed
Jul 4, 2024
| @@ -64,6 +64,8 @@ function (string $carry, string $key) { | |||
| $value = 'true'; | |||
| } | |||
|
|
|||
| $key = str_replace('::', ':', $key); | |||
There was a problem hiding this comment.
In a regex to enforce it's only for nested attributes ? (so after a word / before another one) ?
|
So we close this one or do we want to have both ? |
|
I'm going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you require a Twig component attribute that includes a
:(likex-on:click) you'll trigger the nested attribute system. This PR allows escaping:with::. So to renderx-on:click="!open", you can to writex-on::click="!open".